[PATCH 2/3] cpufreq: s3c: remove last use of resume_clocks callback

Viresh Kumar viresh.kumar at linaro.org
Wed Jan 28 19:23:31 PST 2015


On 28 January 2015 at 18:46, Arnd Bergmann <arnd at arndb.de> wrote:
> Commit 32726d2d550 ("ARM: SAMSUNG: Remove legacy clock code")
> already removed the callback pointer, but there was one remaining
> user:
>
> drivers/cpufreq/s3c24xx-cpufreq.c: In function 's3c_cpufreq_resume_clocks':
> drivers/cpufreq/s3c24xx-cpufreq.c:149:14: error: 'struct s3c_cpufreq_info' has no member named 'resume_clocks'
>   cpu_cur.info->resume_clocks();
>               ^
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Fixes: 32726d2d550 ("ARM: SAMSUNG: Remove legacy clock code")
> Cc: stable at vger.kernel.org # v3.17+
> ---
>  drivers/cpufreq/s3c24xx-cpufreq.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
> index bd340a1ca87d..733aa5153e74 100644
> --- a/drivers/cpufreq/s3c24xx-cpufreq.c
> +++ b/drivers/cpufreq/s3c24xx-cpufreq.c
> @@ -144,11 +144,6 @@ static void s3c_cpufreq_setfvco(struct s3c_cpufreq_config *cfg)
>         (cfg->info->set_fvco)(cfg);
>  }
>
> -static inline void s3c_cpufreq_resume_clocks(void)
> -{
> -       cpu_cur.info->resume_clocks();
> -}
> -
>  static inline void s3c_cpufreq_updateclk(struct clk *clk,
>                                          unsigned int freq)
>  {
> @@ -417,9 +412,6 @@ static int s3c_cpufreq_resume(struct cpufreq_policy *policy)
>
>         last_target = ~0;       /* invalidate last_target setting */
>
> -       /* first, find out what speed we resumed at. */
> -       s3c_cpufreq_resume_clocks();
> -
>         /* whilst we will be called later on, we try and re-set the
>          * cpu frequencies as soon as possible so that we do not end
>          * up resuming devices and then immediately having to re-set

Acked-by: Viresh Kumar <viresh.kumar at linaro.org>



More information about the linux-arm-kernel mailing list