N900 v3.19-rc5 arm atags_to_fdt.c is broken
Tony Lindgren
tony at atomide.com
Tue Jan 27 07:26:53 PST 2015
* Nicolas Pitre <nicolas.pitre at linaro.org> [150127 07:19]:
> On Tue, 27 Jan 2015, Pavel Machek wrote:
>
> >
> > > > > I would say, problem is because omap3-n900 binary DT is too large
> > >
> > > I agree.
> > >
> > > > OK if that's the case, then your patch makes sense to me. It also
> > > > seems we can have the temporary stack be larger than the initial
> > > > stack just for atags_to_fdt.
> > >
> > > The stack size isn't the issue, but rather its location. We need to
> > > position it away from the DT data. The DT size is known and we could
> > > use that, plus some room for the insertion of new data coming from the
> > > ATAG conversion.
> > >
> > > Something like the following would be a more robust solution:
> >
> > Tested-by: Pavel Machek <pavel at ucw.cz>
> >
> > (Note, that in 3.19 dts for n900 got too big, so we are actually
> > triggering old bugs. That means that this is a regression fix, and
> > should go in ASAP).
>
> It is queued here:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8294/1
Thanks for fixing that one!
Regards,
Tony
More information about the linux-arm-kernel
mailing list