[PATCH 4/4] tty: Remove external interface for tty_set_termios()

Marcel Holtmann marcel at holtmann.org
Sun Jan 25 12:36:32 PST 2015


Hi Peter,

> tty_set_termios() is an internal helper intended for file scope use.
> 
> UART drivers which are capable of driving the RTS pin must
> properly handle the tiocmset() method, regardless of termios settings.
> A failure to do so is a UART driver bug and should be fixed there.
> Do not use this interface to workaround UART driver bugs.
> 
> Cc: Marcel Holtmann <marcel at holtmann.org>
> Cc: Johan Hedberg <johan.hedberg at gmail.com>
> Cc: <linux-bluetooth at vger.kernel.org>
> Signed-off-by: Peter Hurley <peter at hurleysoftware.com>
> ---
> drivers/bluetooth/hci_ath.c | 15 ++-------------
> drivers/tty/tty_ioctl.c     |  3 +--
> include/linux/tty.h         |  1 -
> 3 files changed, 3 insertions(+), 16 deletions(-)

I think the less complication is if this goes through the TTY tree.

Acked-by: Marcel Holtmann <marcel at holtmann.org>

Regards

Marcel




More information about the linux-arm-kernel mailing list