[PATCHv5 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs
samuel.thibault at ens-lyon.org
Thu Jan 22 16:44:29 PST 2015
Dmitry Torokhov, le Thu 22 Jan 2015 16:37:02 -0800, a écrit :
> On Friday, January 23, 2015 01:30:11 AM Samuel Thibault wrote:
> > Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit :
> > > Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
> > > > > + dev = cdev->dev->platform_data;
> > > >
> > > > Umm, platform data is not the best place for storing this. Why not
> > > > drvdata?
> > >
> > > Ah, actually led_classdev already makes use of it, see the
> > > device_create_with_groups call in led_classdev_register.
> > Actually I'd say it makes sense to be using the platform_data field:
> > from the point of view of the led object, the input object is indeed
> > something like a platform.
> No, platform data is what difefrentiates an arm board from another arm board,
> or an x86 or mips one.
>From the point of view of a device connected to that board, yes. But
from the point of view of LEDs connected to a keyboard, the platform is
More information about the linux-arm-kernel