[RFC PATCH v4 3/4] arm64:thunder: Add initial dts for Cavium's Thunder SoC in 2 Node topology.

Arnd Bergmann arnd at arndb.de
Thu Jan 22 10:26:09 PST 2015


On Thursday 22 January 2015 17:47:13 Arnd Bergmann wrote:
> 
> This seems wrong still: The clusters and cores do not have unique
> numbers. I believe the code will not work correctly, and it won't
> be compliant with the binding from patch 2.
> 
> I think the right way here would be to use 
> 
>         arm,associativity = <0 2 47>;
> 
> for cpu at 20f, and
> 
>         arm,associativity = <1 3 48>;
> 
> for cpu at 10000. Your previous version used the numbers from 
> the reg property, which should be fine as well if that helps:
> 
> 
>         arm,associativity = <0x0 0x200 0x20f>;
> 
>         arm,associativity = <0x10000 0x10000 0x10000>;
> 
> which should have the same effect as above, as long as the code
> can handle the numbers not being consecutive.
> 
> 

Upon further consideration, I think your patch is correct after
all, but let me check again on PowerPC machines.

	Arnd



More information about the linux-arm-kernel mailing list