[PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3

[Eduardo Valentin]

On Sun, Jan 18, 2015 at 09:18:21PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > Ok, what do you suggest? AFAICT, without MODE_CONFIG, continuous ADC
> > > mode is not available, so we have to force it periodically, so this
> > > should be correct.
> > 
> > I will have a better look and let you know. for now, adding a single
> > read should not hurt ( but I will double check)
> 
> Any news there?

I believe it is OK to keep your code the way you posted.

Thanks.

> 
> > > > > +		if (ret)
> > > > > +			return ret;
> > > > > +	}
> > > > > +
> > > > >  	spin_lock(&bgp->lock);
> > > > >  	temp = ti_bandgap_read_temp(bgp, id);
> > > > >  	spin_unlock(&bgp->lock);
> > > > >  
> > > > > -	ret |= ti_bandgap_adc_to_mcelsius(bgp, temp, &temp);
> > > > > +	ret = ti_bandgap_adc_to_mcelsius(bgp, temp, &temp);
> > > > 
> > > > this one should be part of your clean up patch
> > > 
> > > Ok, can you apply the cleanup patch and I'll prepare one on the top of
> > > it?
> > 
> > I mean, you should resend the cleanup patch including the above '|=' removal, as you are already doing in the cleanup patch.
> > 
> 
> Ok, little patch-editing can not hurt :-).
> 
> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150121/cbab2d4c/attachment.sig>