[RFC PATCHv2 07/19] mfd: ab8500: Use power_supply_*() API for accessing function attrs
pavel at ucw.cz
Tue Jan 20 08:06:03 PST 2015
On Tue 2015-01-20 15:51:49, Lee Jones wrote:
> On Tue, 20 Jan 2015, Krzysztof Kozlowski wrote:
> > On wto, 2015-01-20 at 13:36 +0000, Lee Jones wrote:
> > > On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:
> > >
> > > > Replace direct calls to power supply function attributes with wrappers.
> > > > Wrappers provide safe access in case of unregistering the power
> > > > supply (e.g. by removing the driver). Replace:
> > > > - get_property -> power_supply_get_property
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> > > > Acked-by: Jonghwa Lee <jonghwa3.lee at samusng.com>
> > > > Acked-by: Pavel Machek <pavel at ucw.cz>
> > > > Acked-by: Lee Jones <lee.jones at linaro.org>
> > >
> > > You've sent this to me already Acked. I don't see 00/00, so I have no
> > > idea what's going on. Do you want me to take this patch? Can it be
> > > taking on its own?
> > git send-email automatically CC-you because you acked this. The depends
> > on previous patches adding this API so please do not pick it up.
> You should always send MFD related patches to me (either
> automatically, or manually).
> > Everything (with respective acks) should go through one power supply
> > tree.
> That's not how it works. We need to decide that amongst ourselves
> and it needs to culminate in pull-requests being sent out to all of
> the effected Maintainers.
So go ahead and decide. If the patches are ok, I see no problem in it
going through power supply tree, and neither should you. I feel you
are making it more complex than it is.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
More information about the linux-arm-kernel