[PATCH] USB: host: ehci_atmel: Add suspend/resume support

Alexandre Belloni alexandre.belloni at free-electrons.com
Sun Jan 18 16:17:05 PST 2015


On 17/01/2015 at 17:03:04 +0100, Sylvain Rochet wrote :
> Should I have added the "Acked-by: Alexandre Belloni 
> <alexandre.belloni at free-electrons.com>" on 1/2 ?
> 

Yes, you could. Just a small remark, you send both patches as separate
in v1, you should have kept them separate so it is easier to understand
what v2 is relating to. Also, I don't think you need to use
--in-reply-to when sending v2.

Finally, please including a changelog after the '---' marker in each patch
or in the cover letter.

Those are simply small things and your work is great.

> As a side note, unfortunately AT91 slow clock mode only work on "recent" 
> boards with Wenyou changes on linux4sam/linux-at91/linux-3.10-at91 
> branch and is why I am still stuck to this branch (and the HLCDC FB 
> driver, but this is going to be merged soon from what I saw, YAY !).
> 

Work is in progress to get that in 3.20 or 3.21.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list