[PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

[Boris Brezillon]

Hi Sylvain,

On Sat, 17 Jan 2015 23:49:00 +0100
Sylvain Rochet <sylvain.rochet at finsecur.com> wrote:

> Hi Sergei,
> 
> 
> On Sun, Jan 18, 2015 at 01:22:38AM +0300, Sergei Shtylyov wrote:
> > 
> >    There's little inconsistency in your patch subjects: you're using
> > '_' but the files you're modifying are named using '-'...
> 
> Indeed.
> 
> 
> > >@@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {
> > >  	.probe		= ehci_atmel_drv_probe,
> > >  	.remove		= ehci_atmel_drv_remove,
> > >  	.shutdown	= usb_hcd_platform_shutdown,
> > >+	.suspend	= ehci_atmel_drv_suspend,
> > >+	.resume		= ehci_atmel_drv_resume,
> > 
> >    I think you should use 'struct dev_pm_ops' now.
> 
> This way ?
> 
> static int ehci_atmel_drv_suspend(struct device *dev)
> {
> 	struct usb_hcd *hcd = dev_get_drvdata(dev);
> (...)
> 
> 
> static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend, ehci_atmel_drv_resume);
> 
> (...)
> 	.driver         = {
> 		.pm     = &ehci_atmel_pm_ops,
> 	}
> (...)
> 
> 
> Should I send a v4 or can I send this change separately on top of the 
> previous change ?

I think it's better to send a v4 reworking this patch (you'll have to
change your commit subject anyway ;-)).

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com