[PATCH] PCI: xilinx: fix harmless format string warning

Maxime Coquelin maxime.coquelin at st.com
Tue Jan 13 06:43:11 PST 2015


Hi Arnd,

On 01/13/2015 03:20 PM, Arnd Bergmann wrote:
> The xilinx pcie driver prints a register value whose type is
> propagated to the type returned by the GENMASK() macro.
> Unfortunately, that type has recently changed as the result
> of a bug fix, so now we get a warning about the type:
>
> drivers/pci/host/pcie-xilinx.c: In function 'xilinx_pcie_clear_err_interrupts':
> drivers/pci/host/pcie-xilinx.c:154:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
>
> This changes the code so we always print the number as an
> 'unsigned long' type to avoid the warning. The original code
> was fine on 32-bit architectures but not on 64-bit. Now it
> works as expected on both.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Fixes: 00b4d9a1412 ("bitops: Fix shift overflow in GENMASK macros")
>
>

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin at st.com>

Thanks!
Maxime



More information about the linux-arm-kernel mailing list