[PATCH 1/2] ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi
Hans de Goede
hdegoede at redhat.com
Tue Jan 13 04:32:41 PST 2015
Hi,
On 13-01-15 13:11, Sergei Shtylyov wrote:
> Hello.
>
> On 1/13/2015 1:47 PM, Hans de Goede wrote:
>
>> The A23 has the same lradc controller as previous Allwinner SoCs.
>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>> arch/arm/boot/dts/sun8i-a23.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/sun8i-a23.dtsi b/arch/arm/boot/dts/sun8i-a23.dtsi
>> index a31842d..c2ceafb 100644
>> --- a/arch/arm/boot/dts/sun8i-a23.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a23.dtsi
>> @@ -419,6 +419,13 @@
>> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>> + lradc: lradc at 01c22800 {
>> + compatible = "allwinner,sun4i-a10-lradc-keys";
>
> If this is a keyboard controller, its node name should probably be "keyboard", according to the ePAPR standard...
I'm not sure this qualifies as a keyboard controller, more over we
already have the same name in all other sun?i-a*.dtsi files, so if
we fix this it should be fixed by a follow up patch, and be fixed
everywhere.
Regards,
Hans
More information about the linux-arm-kernel
mailing list