[PATCH RESEND] reset: sunxi: fix spinlock initialization

Tyler Baker tyler.baker at linaro.org
Mon Jan 12 16:41:58 PST 2015


On 12 January 2015 at 14:13, Olof Johansson <olof at lixom.net> wrote:
> On Mon, Jan 12, 2015 at 05:17:06PM +0100, Maxime Ripard wrote:
>> On Mon, Jan 12, 2015 at 07:54:46AM -0800, Tyler Baker wrote:
>> > Call spin_lock_init() before the spinlocks are used, both in early init
>> > and probe functions preventing a lockdep splat.
>> >
>> > I have been observing lockdep complaining [1] during boot on my a80 optimus [2]
>> > when CONFIG_PROVE_LOCKING has been enabled. This patch resolves the splat,
>> > and has been tested on a few other sunxi platforms without issue.
>> >
>> > [1] http://storage.kernelci.org/next/next-20150107/arm-multi_v7_defconfig+CONFIG_PROVE_LOCKING=y/lab-tbaker/boot-sun9i-a80-optimus.html
>> > [2] http://kernelci.org/boot/?a80-optimus
>> >
>> > Signed-off-by: Tyler Baker <tyler.baker at linaro.org>
>> > Cc: <stable at vger.kernel.org>
>>
>> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>
> Not entirely sure what to do with this one. You sent it to:arm at kernel.org, but
> it should probably have gone to Philipp?

Apologies, that was my copy and paste error.

>
> We can pick it up with an ack from him though, no problem.

Philipp is on CC so I'll let him decide, otherwise I can resend if needed.

>
>
> -Olof

Sorry for any confusion.

-- 
Tyler Baker
Tech Lead, LAVA
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog



More information about the linux-arm-kernel mailing list