[PATCH] ARM: fix v7M build for !CONFIG_PRINTK

Rob Herring robh at kernel.org
Mon Jan 12 07:38:52 PST 2015


On Mon, Jan 12, 2015 at 2:29 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Sunday 11 January 2015 22:25:49 Rob Herring wrote:
>>
>>  __invalid_entry:
>>         v7m_exception_entry
>> +#ifdef CONFIG_PRINTK
>>         adr     r0, strerr
>>         mrs     r1, ipsr
>>         mov     r2, lr
>>         bl      printk
>> +#endif
>>         mov     r0, sp
>>         bl      show_regs
>>  1:     b       1b
>>
>
> Should the show_regs call be commented out as well? While
> the function is still there without printk support, I believe
> it doesn't actually do anything.

It does still call unwind_backtrace which still constructs the
backtrace from looking at the disassembly output. That's probably not
too useful unless it is saved to memory that could be examined with a
debugger. One would probably just enable printk at that point though.

Rob



More information about the linux-arm-kernel mailing list