[PATCH v2 07/21] genirq: Add irqchip_set_wake_parent

Marc Zyngier marc.zyngier at arm.com
Sat Jan 10 04:46:22 PST 2015


On 2015-01-08 15:15, Nishanth Menon wrote:
> On 17:42-20150107, Marc Zyngier wrote:
>> This proves to be usefull with stacked domains, when the current
> 			^^ useful ?
> minor:
> +WARNING: 'usefull' may be misspelled - perhaps 'useful'?
> +#6:
> +This proves to be usefull with stacked domains, when the current
> +CHECK: extern prototypes should be avoided in .h files
> +#23: FILE: include/linux/irq.h:463:
> ++extern int irq_chip_set_wake_parent(struct irq_data *data, unsigned
> int on);

Consistency trumps whatever checkpatch says, I'm afraid.

Thanks,

         M.
-- 
Fast, cheap, reliable. Pick two.



More information about the linux-arm-kernel mailing list