[PATCH] soc/tegra: pmc: Add Tegra132 support
Paul Walmsley
paul at pwsan.com
Fri Jan 9 12:02:57 PST 2015
On Fri, 9 Jan 2015, Thierry Reding wrote:
> On Thu, Jan 08, 2015 at 10:34:35PM +0000, Paul Walmsley wrote:
> > On Thu, 8 Jan 2015, Thierry Reding wrote:
> >
> > > From: Thierry Reding <treding at nvidia.com>
> > >
> > > Tegra132 uses the same GPU as Tegra124 and the same special-case is
> > > needed to remove clamps. However Tegra132 has a separate chip ID, so in
> > > order to avoid having to extend the list of chip IDs for the special
> > > case, add a feature flag to the SoC data.
> > >
> > > Signed-off-by: Thierry Reding <treding at nvidia.com>
> >
> > Reviewed-by: Paul Walmsley <pwalmsley at nvidia.com>
> >
> > Nit: not sure I would call it a special-case; to me it's more of an
> > evolutionary change due to the radically different GPU in T124 & T132.
>
> I reworded the commit message slightly, so it says:
>
> Tegra132 uses the same GPU as Tegra124 and therefore requires the same
> method to remove clamps. ...
>
> I hope that's less misleading.
Looks good to me,
- Paul
More information about the linux-arm-kernel
mailing list