[PATCH 3/4] arm64: dts: Add APM X-Gene PCIe DMA device tree nodes

[Mayuresh Chitale]

Hi Arnd,

Actually the addresses are different. For e.g port 0 base address is
1F2B0000 and port 1 base address is 1F2C0000 and so on.

Thanks,
Mayuresh.

On Wed, Jan 7, 2015 at 2:07 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 07 January 2015 10:58:56 Mayuresh Chitale wrote:
>>
>> +               xpdma0: dma0 at 1f2b0154 {
>> +                       status = "disabled";
>> +                       compatible = "apm,xgene-pciedma";
>> +                       reg = < 0x0 0x1f2b0154 0x0 0xc
>> +                               0x0 0x1f2b0058 0x0 0x8>;
>> +                       interrupts = <0x0 0xc6 0x4>;
>> +               };
>> +
>> +               xpdma1: dma1 at 1f2c0154 {
>> +                       status = "disabled";
>> +                       compatible = "apm,xgene-pciedma";
>> +                       reg = < 0x0 0x1f2c0154 0x0 0xc
>> +                               0x0 0x1f2c0058 0x0 0x8>;
>> +                       interrupts = <0x0 0xcc 0x4>;
>> +               };
>> +
>>
>
> Something's wrong here: you have the same addresses for
> all the nodes but use different names. Please change the names
> to all say 'dma' and set the correct addresses.
>
>         Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html