[PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check
jason at lakedaemon.net
Tue Jan 6 18:08:14 PST 2015
On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote:
> Beniamino reported a kernel oops caused by an invalid DT file for the
> mediatek interrupt polarity extension.
> The reason is that the interrupt polarity support for mediatek chips
> merely checks for NULL pointer instead of a casted error return
> value in mtk_sysirq_of_init() so any other casted error value passes
> the NULL pointer check and causes a kernel panic when dereferenced.
> Use IS_ERR() and return the error value via PTR_ERR().
> Reported-and-tested-by: Beniamino Galvani <b.galvani at gmail.com>
> Signed-off-by: Yingjoe Chen <yingjoe.chen at mediatek.com>
> drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I applied V2 to irqchip/urgent, and hand-added the changes from V3
because the email formatting was wrong. I also tweaked the subject
More information about the linux-arm-kernel