[PATCH 3/4] arm64: fix missing asm/alternative.h include in kernel/module.c

Mark Rutland mark.rutland at arm.com
Tue Jan 6 02:40:08 PST 2015


On Tue, Jan 06, 2015 at 01:52:20AM +0000, Paul Walmsley wrote:
> On next-20150105, defconfig compilation breaks with:
> 
> arch/arm64/kernel/module.c:408:4: error: implicit declaration of function ‘apply_alternatives’ [-Werror=implicit-function-declaration]
> 
> Fix by including asm/alternative.h, where the apply_alternatives()
> prototype is declared.
> 
> Signed-off-by: Paul Walmsley <paul at pwsan.com>
> Cc: Paul Walmsley <pwalmsley at nvidia.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Will Deacon <will.deacon at arm.com>
> ---
>  arch/arm64/kernel/module.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c
> index fd027b101de5..ac081d6fe184 100644
> --- a/arch/arm64/kernel/module.c
> +++ b/arch/arm64/kernel/module.c
> @@ -27,6 +27,7 @@
>  #include <linux/vmalloc.h>
>  #include <asm/insn.h>
>  #include <asm/sections.h>
> +#include <asm/alternative.h>

If this can move above the include of asm/insn.h:

Acked-by: Mark Rutland <mark.rutland at arm.com>

Thanks,
Mark.

>  
>  #define	AARCH64_INSN_IMM_MOVNZ		AARCH64_INSN_IMM_MAX
>  #define	AARCH64_INSN_IMM_MOVK		AARCH64_INSN_IMM_16
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list