[PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency

Kukjin Kim kgene at kernel.org
Thu Feb 26 12:52:52 PST 2015


On 02/18/15 07:24, Stephen Boyd wrote:
> On 02/16/15 05:36, Krzysztof Kozlowski wrote:
>> During CPU shutdown the exynos_cpu_power_down() is called after
>> disabling cache coherency and it uses LDREX and STREX instructions (by
>> calling of_machine_is_compatible() -> kobject_get() -> kref_get()).
>>
>> The LDREX and STREX should not be used after disabling the cache
>> coherency so just use soc_is_exynos().
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
>> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420")
>> Cc: <stable at vger.kernel.org>
>> Reported-by: Stephen Boyd <sboyd at codeaurora.org>
>> ---
> 
> Looks good to me.
> 
> Reviewed-by: Stephen Boyd <sboyd at codeaurora.org>
> 
Thanks for this fix, applied.

- Kukjin



More information about the linux-arm-kernel mailing list