[PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Guenter Roeck
linux at roeck-us.net
Wed Feb 25 08:20:00 PST 2015
On Wed, Feb 25, 2015 at 04:04:59PM +0100, Andrew Lunn wrote:
> > However, we need to state and check in the code that _some_ property
> > is mandatory. A driver with only optional properties doesn't make
> > sense.
>
> The patch to the binding documentation said:
>
> Note: At least one the "gpios" and "alarm-gpios" properties should be set.
>
> which i then suggested should be:
>
> Note: At least one of "gpios" or "alarm-gpios" properties should be set.
>
"should" is not "must".
Guenter
> What we could do is move this sentence into the Required Properties of
> the documentation.
>
> The patch Simon submitted also does check that this condition is
> fulfilled.
>
> Andrew
>
>
>
More information about the linux-arm-kernel
mailing list