[PATCH v3 2/9] ACPI: clear up warnings on use of printk reported by checkpatch.pl
Hanjun Guo
hanjun.guo at linaro.org
Wed Feb 25 04:55:41 PST 2015
On 2015年02月25日 08:36, al.stone at linaro.org wrote:
> From: Al Stone <al.stone at linaro.org>
>
> In preparation for later splitting out some of the arch-dependent code from
> osl.c, clear up all the warnings reported by checkpatch.pl where pr_* should
> be used instead of printk(KERN_* ...).
>
> Signed-off-by: Al Stone <al.stone at linaro.org>
> ---
> drivers/acpi/osl.c | 46 +++++++++++++++++++---------------------------
> 1 file changed, 19 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 1dc3a3b..865317c 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -141,7 +141,7 @@ static u32 acpi_osi_handler(acpi_string interface, u32 supported)
> {
> if (!strcmp("Linux", interface)) {
>
> - printk_once(KERN_NOTICE FW_BUG PREFIX
> + pr_notice_once(FW_BUG PREFIX
I think you can use pr_fmt() and then remove all the PREFIX in
this patch, just
#define pr_fmt(fmt) "ACPI: " fmt
in top of this file before all #includes.
Thanks
Hanjun
More information about the linux-arm-kernel
mailing list