[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Thu Feb 19 09:02:56 PST 2015


Hello.

On 02/19/2015 07:10 PM, Simon Horman wrote:

>> Define the generic R8A7794 part of the MMCIF0 device node.

>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc at renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>

>> ---
>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>   1 file changed, 11 insertions(+)

>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>>   		status = "disabled";
>>   	};
>>
>> +	mmcif0: mmc at ee200000 {
>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.

    That file doesn't match the reality at all. It says:

<<
- compatible: must contain one of the following
         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
         - "renesas,sh-mmcif" for the generic MMCIF
 >>

while in reality, the driver only matches on the latter string and doesn't 
care for the SoC specific strings.

WBR, Sergei




More information about the linux-arm-kernel mailing list