[PATCH] i.MX6: WEIM: put node reference on early loop exit

Chaiken, Alison Alison_Chaiken at mentor.com
Tue Feb 17 08:28:28 PST 2015


Sascha Hauer <s.hauer at pengutronix.de>
>Looking at the code I get the question why the current code bails out on
>error. Wouldn't it be better to just skip erroneous child devices and
>issue a warning?

The WEIM connects only one child at any given time.   Since it is a platform device, any child is cold-plugged.   If the probe of the child that is marked 'status = "okay"' in the device-tree fails, then the WEIM itself has no function, which sounds more like an error than a warning state.

-- Alison



More information about the linux-arm-kernel mailing list