[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[gwenhael.goavec]

Hi,

On Fri, 13 Feb 2015 15:53:58 +0100
Lothar Waßmann <LW at KARO-electronics.de> wrote:

> Hi,
> 
> Gwenhael Goavec-Merou wrote:
> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at armadeus.com>
> > Signed-off-by: Sebastien Szymanski <sebastien.szymanski at armadeus.com>
> > ---
> >  arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> > index 68405c3..a052d3e 100644
> > --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> > +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> > @@ -110,6 +110,13 @@
> >  					};
> >  				};
> >  			};
> > +
> > +			can0: can at 80032000 {
> >
> Did you compile-test this? It should produce a build error, since
> the label can0 already exists in imx28.dtsi.
Compile fine and without error. It's the same thing for all labels in 
this dts file.
> You should use:
> |&can0 {
> |				pinctrl-names = "default";
> |				pinctrl-0 = <&can0_pins_a>;
> |				xceiver-supply = <&reg_can0_vcc>;
> |				status = "okay";
> |};
> 
> > @@ -176,6 +183,14 @@
> >  			gpio = <&gpio1 23 1>;
> s/ 1/ GPIO_ACTIVE_LOW/ ?
> 
This change is out of the context to this patch. This change will be done in
other patch.
> 
> Lothar Waßmann
> -- 
Gwenhael Goavec-Merou