[PATCH RFC 0/5] ARM: dts: zynq: pinctrl, LED, USB for Parallella

Sören Brinkmann soren.brinkmann at xilinx.com
Wed Feb 11 19:31:47 PST 2015


On Thu, 2015-02-12 at 03:58AM +0100, Andreas Färber wrote:
> Hi Sören,
> 
> Am 12.02.2015 um 02:19 schrieb Sören Brinkmann:
> > I'm just thinking out loud here. I think it's reasonable to have a dts
> > for each platform/board. On dtsi files the opinions seem to diverge,
> > but as long as it isn't a completely confusing include scheme,
> > I'm always for minimizing duplication.
> > But what I'm not convinced of is, additional dts files for different
> > bitstreams. The amount of variation you can achieve by programming
> > different bitstreams is virtually unlimited. Having a dts file for all
> > of that upstream doesn't seem that reasonable to me.
> 
> Hm, for your Xilinx boards or for the Zed board I would agree. However,
> Adapteva specifically offers two alternative bitstreams per board:
> https://github.com/parallella/parallella-hw/tree/master/fpga/bitstreams
> ftp://ftp.parallella.org/boot/linux/
> 
> Don't you think it's reasonable to support those official two, while
> letting people who tinker with bitstreams themselves worry about their
> own device trees?
> 
> Personally I use the HDMI bitstream (despite the ADI AXI HDMI driver
> still missing, i.e. headless), so I don't insist on having headless DTs.
> 
> From a distro perspective we'd put just one bitstream (HDMI probably) in
> a JeOS image and would set it up to use the matching device tree. On the
> other hand, if we were providing both bitstreams and had both dtbs
> packaged, then switching would be two file copies or a boot.scr update.
> So far the FAT boot partition has kept me from preparing such an image,
> don't know how far other distros are here.
> 
> I'll leave it to Ola and Andreas O. to comment on how widely the
> headless bitstream is used. But as a reminder, it was you Sören who
> discouraged me from adding VDMA etc. to the device tree in case the
> bitstream doesn't provide it:
> https://patchwork.kernel.org/patch/4620231/
> Therefore I've prepared said headless vs. HDMI DT split. ;)

Yeah, I vaguely remember that we had this topic before. And in the end,
it's not my decision. I just think, it needs to be discussed what to
achieve with the DTs that are upstream and where to draw the line (or
maybe there is already a policy that I'm not aware of).

> 
> > So, I'd say it needs parallella-{userver, e16, e64} (conceptually, the
> > names I don't care). I think it should be possible for all of those to
> > inherit from zynq-7000.dtsi or is there a reason to have a parallella
> > dtsi?
> 
> It would be possible, but it would result in duplication. For the Exynos
> Chromebooks we decided that there were not enough common bits, so we
> inlined an existing .dtsi and I've been using manual diff -u for
> checking which bits people forgot to sync (and I do have a local patch
> fixing some things that went out of sync that I need to submit...).
> 
> In this case it seems the "same" board with some components left out. We
> could duplicate the PHYs for instance (which are physically absent for
> the Microserver IIUC), but I'd rather not duplicate all those gory
> pinctrl settings.

Fair enough. Though, since the userver doesn't have USB even pinctrl
would differ.

	Soren



More information about the linux-arm-kernel mailing list