[PATCH 6/6] [RFC] mtd: mxc-nand: Warn on unimplemented commands

[Uwe Kleine-König]

Hello Lothar,

On Wed, Feb 11, 2015 at 09:42:56AM +0100, Lothar Waßmann wrote:
> > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> > index 0083b4ee4f33..372e0e38f59b 100644
> > --- a/drivers/mtd/nand/mxc_nand.c
> > +++ b/drivers/mtd/nand/mxc_nand.c
> > @@ -1160,6 +1160,10 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
> >  		memcpy32_fromio(host->data_buf, host->main_area0, 512);
> >  		host->buf_start = 0;
> >  		break;
> > +	default:
> > +		WARN_ONCE(1, "Unimplemented command (cmd=%u)\n",
> > +			  command);
> > +		break;
> >  	}
> useless break;
Do you mean the line break? That's right, I fixed it here for a later
v2. But I guess you mean the (literal) break here. Right, it could be
dropped without change in semantic, but I thought adding it matches the
usually recommended style?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |