[PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs

Krzysztof Kozlowski k.kozlowski at samsung.com
Mon Feb 9 23:39:19 PST 2015


On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote:
> Hi Krzysztof,
> 
> > Krzysztof Kozlowski <k.kozlowski at samsung.com> hat am 30. Januar 2015 um 15:47
> > geschrieben:
> >
> >
> > Replace direct calls to power supply function attributes with wrappers.
> > Wrappers provide safe access in case of unregistering the power
> > supply (e.g. by removing the driver). Replace:
> > - get_property -> power_supply_get_property
> > - set_property -> power_supply_set_property
> > - property_is_writeable -> power_supply_property_is_writeable
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> > Acked-by: Jonghwa Lee <jonghwa3.lee at samusng.com>
> 
> just a nit. It looks like a typo in the mail address which is also in patch 5 -
> 10.

Right, I copied it directly from Jonghwa's response. Thank you for
noticing it.

> 
> I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and
> didn't see any problems with your patches.

Great, thanks!

Best regards,
Krzysztof





More information about the linux-arm-kernel mailing list