[PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

Robert Jarzmik robert.jarzmik at free.fr
Sat Dec 19 05:26:28 PST 2015


Robert Jarzmik <robert.jarzmik at free.fr> writes:

> Sergei Ianovich <ynvich at gmail.com> writes:
>
>> pxa2xx-uart was a separate uart platform driver. It was declaring
>> the same device names and numbers as 8250 driver. As a result,
>> it was impossible to use 8250 driver on PXA SoCs.
>>
>> Upon closer examination pxa2xx-uart turned out to be a clone of
>> 8250_core driver.
>>
>> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
>> Specification Update (April 19, 2010) is dropped. 8250_core reads
>> from FIFO immediately after checking DR bit in LSR.
>>
>> Signed-off-by: Sergei Ianovich <ynvich at gmail.com>
>> Reviewed-by: Heikki Krogerus <heikki.krogerus at linux.intel.com>
>> Reviewed-by: James Cameron <quozl at laptop.org>
>> Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Tested-by: Robert Jarzmik <robert.jarzmik at free.fr>

Shrunk the list, the following is rather mach-pxa specific.

Actually there is a small glitch ...
Have a look at arch/arm/mach-pxa/viper.c, line 490:
	#ifndef CONFIG_SERIAL_PXA
	...

But that can be handled in an subsequent patch to keep your acks and reviews.

Cheers.

-- 
Robert



More information about the linux-arm-kernel mailing list