[RFC PATCH v3 5/5] PCI: ACPI: Add a generic ACPI based host controller

Arnd Bergmann arnd at arndb.de
Fri Dec 18 02:35:03 PST 2015


On Wednesday 16 December 2015 18:12:35 Jayachandran C wrote:
> Add a simple ACPI based PCI host controller. This is done by
> providing a simple implementation for pci_acpi_scan_root().
> 
> The pci_mmcfg_list handling is done by the ACPI code, we
> keep a reference to the pci_mmcfg_region which is already
> mapped.
> 
> This is enabled only for ARM64 now.
> 
> Signed-off-by: Jayachandran C <jchandra at broadcom.com>
> ---
>  drivers/pci/host/Kconfig         |   7 ++
>  drivers/pci/host/Makefile        |   1 +
>  drivers/pci/host/pci-host-acpi.c | 193 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 201 insertions(+)
>  create mode 100644 drivers/pci/host/pci-host-acpi.c

(just noticed this got stuck in my outbox, sending it late)

I think this would be better put into drivers/acpi/pci_root.c, it directly
interacts with the code that is already there, and it's by no means
a standalone driver.

Also, there is no need for a Kconfig symbol that way.

You can put it into #if !(defined(CONFIG_X86) || defined(CONFIG_IA64))
if the code cannot be shared with the other architectures at the moment.

	Arnd



More information about the linux-arm-kernel mailing list