[PATCH v2 3/3] iommu/io-pgtable: Avoid redundant TLB syncs

Robin Murphy robin.murphy at arm.com
Thu Dec 17 12:50:59 PST 2015

In certain unmapping situations it is quite possible to end up issuing
back-to-back TLB synchronisations, which at best is a waste of time and
effort, and at worst causes some hardware to get rather confused. Whilst
the pagetable implementations, or the IOMMU drivers, or both, could keep
track of things to avoid this happening, it seems to make the most sense
to prevent code duplication and add some simple state tracking in the
common interface between the two.

Signed-off-by: Robin Murphy <robin.murphy at arm.com>
 drivers/iommu/io-pgtable.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/io-pgtable.h b/drivers/iommu/io-pgtable.h
index 95c5565..d06219b 100644
--- a/drivers/iommu/io-pgtable.h
+++ b/drivers/iommu/io-pgtable.h
@@ -132,12 +132,14 @@ void free_io_pgtable_ops(struct io_pgtable_ops *ops);
  * @fmt:    The page table format.
  * @cookie: An opaque token provided by the IOMMU driver and passed back to
  *          any callback routines.
+ * @sync_flag: Private flag for optimising out redundant syncs.
  * @cfg:    A copy of the page table configuration.
  * @ops:    The page table operations in use for this set of page tables.
 struct io_pgtable {
 	enum io_pgtable_fmt	fmt;
 	void			*cookie;
+	bool			sync_flag;
 	struct io_pgtable_cfg	cfg;
 	struct io_pgtable_ops	ops;
@@ -147,17 +149,22 @@ struct io_pgtable {
 static inline void io_pgtable_tlb_flush_all(struct io_pgtable *iop)
+	iop->sync_flag = true;
 static inline void io_pgtable_tlb_add_flush(struct io_pgtable *iop,
 		unsigned long iova, size_t size, size_t granule, bool leaf)
 	iop->cfg.tlb->tlb_add_flush(iova, size, granule, leaf, iop->cookie);
+	iop->sync_flag = true;
 static inline void io_pgtable_tlb_sync(struct io_pgtable *iop)
-	iop->cfg.tlb->tlb_sync(iop->cookie);
+	if (iop->sync_flag) {
+		iop->cfg.tlb->tlb_sync(iop->cookie);
+		iop->sync_flag = false;
+	}

More information about the linux-arm-kernel mailing list