[PATCH] net: add Qualcomm IPC router

David Miller davem at davemloft.net
Tue Dec 15 13:01:14 PST 2015


From: Bjorn Andersson <bjorn.andersson at sonymobile.com>
Date: Fri, 11 Dec 2015 12:41:59 -0800

> +static unsigned int qrtr_local_nid = 1;
> +module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
> +MODULE_PARM_DESC(idVendor, "Local Node Identifier");

Module parameters suck.

Allow the user to choose this dynamically.  You have roughtly two choices.

1) Subvert the 'protocol' field passed to ->create() and use that, it is
   being ignored otherwise.

2) Put it into the socket address for bind().



More information about the linux-arm-kernel mailing list