[PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable
Daniel Thompson
daniel.thompson at linaro.org
Mon Dec 14 02:28:47 PST 2015
On 11/12/15 23:21, Russell King - ARM Linux wrote:
> As I explained when I did that work, the vast majority of ARM platforms
> are unable to trigger anything like a NMI - the FIQ is something that's
> generally a property of the secure monitor, and is not accessible to
> Linux. However, there are platforms where it is accessible.
>
> The work to add the FIQ-based variant never happened (I've no idea what
> happened to that part, Daniel seems to have lost interest in working on
> it.) So, what we have is the IRQ-based variant merged in mainline, which
> would be the fallback for the "FIQ not available" cases, and I carry a
> local hack in my tree which provides the FIQ-based version - but if it
> were to trigger, it takes out all interrupts (hence why I've not merged
> my hack.)
>
> I think the reason that the FIQ-based variant has never really happened
> is that hooking into the interrupt controller code to clear down the FIQ
> creates such a horrid layering violation, and also a locking mess that
> I suspect it's just been given up with.
I haven't quite given up; I'm still looking into this stuff. However
you're certainly right that connecting the FIQ handler to the GIC code
in an elegant way is tough.
I've been working in parallel on an arm64 implementation with the result
that I'm now two lumps of code that are almost, but not quite, ready.
Right now I hope to share latest arm code fairly late in the this
devcycle (for review rather than merge) followed up with a new version
very early in v4.6. Even now I think the code needs a long soak in -next
just in case there are any lurking regressions on particular platforms.
I don't expect anyone to base decisions on my aspirations above but
would like to reassure Russell that I haven't given up on it.
Daniel.
More information about the linux-arm-kernel
mailing list