[PATCH] ARM: ep93xx: Fix clocksource registration
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Dec 10 09:32:36 PST 2015
On Tue, Dec 01, 2015 at 11:14:02AM +0100, Alexander Sverdlin wrote:
> Hello Linus,
> On 01/12/15 11:09, Linus Walleij wrote:
> >> clocksource_mmio_init() explicitly checks for counter's width and refuses to
> >> > register anything with resolution higher than 32 bits. We need to use
> >> > clocksource_register_hz() directly to repair HIGH_RES_TIMERS.
> > Maybe tglx want to jump in on this.
> > Isn't it better to fix clocksource_mmio_init() to accept > 32 bits?
> > What is really prompting this in drivers/clocksource/mmio.c:
> > if (bits > 32 || bits < 16)
> > return -EINVAL;
> probably lack of >32bit access functions in the driver. But I do not know
> the original intentions of the author. In any case, if we modify the check here,
> probably the access function for 64 bits should be moved to the mmio.c?
If people want to use it with 64-bit accessors, then yes. So says
the author of that file (me).
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
More information about the linux-arm-kernel