[PATCH v12 12/16] arm64: kdump: implement machine_crash_shutdown()
takahiro.akashi at linaro.org
Thu Dec 10 03:42:12 PST 2015
On 12/03/2015 01:15 PM, Pratyush Anand wrote:
> Hi Akashi,
> Some of the points which came while discussing with Mark Salter are worth
> including in v13.
> On 24/11/2015:10:25:34 PM, Geoff Levand wrote:
>> From: AKASHI Takahiro <takahiro.akashi at linaro.org>
>> + * machine_crash_shutdown - shutdown non-boot cpus and save registers
> "non-panic" would be correct in stead of "non-boot".
OK, but for consistency with other places (say, arm/kernel/machine_kexec.c)
I prefer "non-crashing cpus."
>> + /* shutdown non-boot cpus */
>> + smp_send_stop();
>> + /* for boot cpu */
> "for panic cpu"
"for crashing cpu"
>> @@ -697,6 +704,11 @@ static void ipi_cpu_stop(unsigned int cpu)
> We have "set_cpu_online(cpu, false);" just before it.
> Panic core is waiting for non-panic to go offline, i.e. for the above event.
>> +#ifdef CONFIG_KEXEC
>> + if (in_crash_kexec)
>> + crash_save_cpu(regs, cpu);
>> +#endif /* CONFIG_KEXEC */
> However, we are still saving crash info for non-panic core. So, it would be good
> to move crash_save_cpu() before set_cpu_online() to avoid any race condition.
Good point, race will be very unlikely though. I will fix it.
More information about the linux-arm-kernel