[PATCH v3] PCI: imx6: Fix reset-gpio to work with active low GPIO
helgaas at kernel.org
Wed Dec 9 07:09:35 PST 2015
[Jingoo's response didn't make it to the list because it contained
HTML, but I incorporated it below manually]
On Tue, Dec 8, 2015 at 11:28 PM, Han Jingoo wrote:
> On Fri, Dec 04, 2015 at 03:02:34PM -0600, Bjorn Helgaas wrote:
> > [+cc Jingoo]
> > On Fri, Dec 04, 2015 at 02:59:06PM -0600, Bjorn Helgaas wrote:
> > > On Fri, Nov 27, 2015 at 11:56:34AM +0100, Petr Štetiar wrote:
> > > > It's currently not possible to use reset-gpio on board where the GPIO is
> > > > active low as the code incorrectly assumes, that reset-gpio will be
> > > > always active high.
> > > >
> > > > In my case the broken behavior was observed on Toradex Apalis SoM with
> > > > Ixora base board.
> > > >
> > > > Signed-off-by: Petr Štetiar <ynezz at true.cz>
> > >
> > > Applied as follows with Lucas' reviewed-by to pci/host-imx6 for v4.5,
> > > thanks!
> > Jingoo, I noticed pci-exynos.c also uses of_get_named_gpio(). Do you
> > care about this issue, too, or are you content to ignore the GPIO
> > flags for your "reset-gpio"?
> Sorry, I don't care about it.
> Also, there is no issue with Exynos platform.
OK, thanks for checking!
More information about the linux-arm-kernel