[PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware
Sunil Kovvuri
sunil.kovvuri at gmail.com
Wed Dec 9 04:24:16 PST 2015
>> + bool tns_mode:1;
>> + bool sqs_mode:1;
>These little refactors are creeping in your code without even being
mentioned in the commit message, this is not good practice.
Okay, will include these in the commit message.
>IMHO. Additionally, may be turn these two flags into something like:
>enum nicvf_mode {
> NICVF_BYPASS,
> NICVF_TNS,
> NICVF_SQS
>};
>? Anyway, these modes are mutually exclusive.
VF driver always assumed to be in BYPASS mode.
Will submit a seperate cleanup patch to get rid of 'tns_mode' boolean.
Thanks,
Sunil.
More information about the linux-arm-kernel
mailing list