[PATCH v2 next 1/2] dts: hisi: fixes no syscon error when init mdio
Rob Herring
robh at kernel.org
Tue Dec 8 07:25:14 PST 2015
On Mon, Dec 07, 2015 at 04:25:06PM +0800, yankejian wrote:
> Signed-nux start up, we get the log below:
> "Hi-HNS_MDIO 803c0000.mdio: no syscon hisilicon,peri-c-subctrl
> mdio_bus mdio at 803c0000: mdio sys ctl reg has not maped "
>
> the source code about the subctrl is dealled with syscon, but dts doesn't.
The source...
s/dealled/dealt/
> it cause such fault. so this patch adds the syscon info on dts files to
> fixes it. and it adds documentation for the devicetree bindings used by
Capitalization please.
> DT files of Hisilicon Hip05-D02 development board.
>
> Signed-off-by: yankejian <yankejian at huawei.com>
> ---
> change log:
> v2:
> 1) updates the related documented in the binding as well
> 2) use the normal naming conventions using '-' instead of '_'
>
> v1:
> initial version
> ---
> .../devicetree/bindings/arm/hisilicon/hisilicon.txt | 16 ++++++++++++++++
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 5 +++++
> arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 4 ++--
> 3 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> index 6ac7c00..9f05767 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> @@ -187,6 +187,22 @@ Example:
> reg = <0xb0000000 0x10000>;
> };
>
> +Hisilicon HiP05 PERISUB system controller
> +
> +Required properties:
> +- compatible : "hisilicon,peri-c-subctrl", "syscon";
> +- reg : Register address and size
> +
> +The HiP05 PERISUB system controller is shared by peripheral controllers in
> +HiP05 Soc to implement some basic configurations. the peripheral
> +controllers include mdio, ddr, iic, uart, timer and so on.
> +
> +Example:
> + /* for HiP05 PCIe-SAS system */
> + peri-c-subctrl: sub-ctrl-c at 80000000 {
s/sub-ctrl-c/syscon/
> + compatible = "hisilicon,peri-c-subctrl", "syscon";
> + reg = <0x0 0x80000000 0x0 0x10000>;
> + };
> -----------------------------------------------------------------------
> Hisilicon CPU controller
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> index 4ff16d0..5fec740 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> @@ -246,6 +246,11 @@
> clock-frequency = <200000000>;
> };
>
> + peri_c_subctrl: sub-ctrl-c at 80000000 {
> + compatible = "hisilicon,peri-c-subctrl", "syscon";
> + reg = < 0x0 0x80000000 0x0 0x10000>;
> + };
> +
> uart0: uart at 80300000 {
> compatible = "snps,dw-apb-uart";
> reg = <0x0 0x80300000 0x0 0x10000>;
> diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
> index 606dd5a..da7b6e6 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
> @@ -10,8 +10,8 @@ soc0: soc at 000000000 {
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "hisilicon,hns-mdio";
> - reg = <0x0 0x803c0000 0x0 0x10000
> - 0x0 0x80000000 0x0 0x10000>;
> + reg = <0x0 0x803c0000 0x0 0x10000>;
> + subctrl-vbase = <&peri_c_subctrl>;
>
> soc0_phy0: ethernet-phy at 0 {
> reg = <0x0>;
> --
> 1.9.1
>
More information about the linux-arm-kernel
mailing list