[PATCH LINUX v4 07/13] tty: xuartps: Keep lock for whole ISR
Soren Brinkmann
soren.brinkmann at xilinx.com
Sat Dec 5 20:39:23 PST 2015
The RX path in the interrupt handler released a lock unnecessarily.
Signed-off-by: Soren Brinkmann <soren.brinkmann at xilinx.com>
Reviewed-by: Peter Hurley <peter at hurleysoftware.com>
---
drivers/tty/serial/xilinx_uartps.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 1e9053656610..62224a58056b 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN,
data, status);
}
- spin_unlock(&port->lock);
tty_flip_buffer_push(&port->state->port);
- spin_lock(&port->lock);
}
/* Dispatch an appropriate handler */
--
2.6.3.3.g9bb996a
More information about the linux-arm-kernel
mailing list