[PATCH v6 04/19] arm64: change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead

Catalin Marinas catalin.marinas at arm.com
Thu Dec 3 04:02:27 PST 2015

On Wed, Nov 18, 2015 at 12:16:44AM +0300, Yury Norov wrote:
> From: Andrew Pinski <apinski at cavium.com>
> Reviewed-by: David Daney <ddaney at caviumnetworks.com>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> Signed-off-by: Christoph Muellner <christoph.muellner at theobroma-systems.com>
> Signed-off-by: Yury Norov <ynorov at caviumnetworks.com>
> Signed-off-by: Andrew Pinski <Andrew.Pinski at caviumnetworks.com>

Please add a long description to every patch, even if it is trivial.

And a nitpick: remove the empty lines between Reviewed-by and
Signed-off-by. These tags usually come in the same block.

> +#else
> +
> +typedef elf_greg_t			compat_elf_greg_t;
> +typedef elf_gregset_t			compat_elf_gregset_t;
> +#define compat_a32_elf_check_arch(x)	0
> +
> +#endif

Do you need these definitions here? I guess they may be used later by
the ILP32 code paths but for A32 compat they don't make much sense (I
haven't made it to the end of the series yet).


More information about the linux-arm-kernel mailing list