[PATCH v12 12/16] arm64: kdump: implement machine_crash_shutdown()
panand at redhat.com
Wed Dec 2 20:15:25 PST 2015
Some of the points which came while discussing with Mark Salter are worth
including in v13.
On 24/11/2015:10:25:34 PM, Geoff Levand wrote:
> From: AKASHI Takahiro <takahiro.akashi at linaro.org>
> + * machine_crash_shutdown - shutdown non-boot cpus and save registers
"non-panic" would be correct in stead of "non-boot".
> + /* shutdown non-boot cpus */
> + smp_send_stop();
> + /* for boot cpu */
"for panic cpu"
> @@ -697,6 +704,11 @@ static void ipi_cpu_stop(unsigned int cpu)
We have "set_cpu_online(cpu, false);" just before it.
Panic core is waiting for non-panic to go offline, i.e. for the above event.
> +#ifdef CONFIG_KEXEC
> + if (in_crash_kexec)
> + crash_save_cpu(regs, cpu);
> +#endif /* CONFIG_KEXEC */
However, we are still saving crash info for non-panic core. So, it would be good
to move crash_save_cpu() before set_cpu_online() to avoid any race condition.
More information about the linux-arm-kernel