[PATCH v2 1/6] ARM: OMAP2+: dts: cm-t335: add initial support

Uri Mashiach uri.mashiach at compulab.co.il
Wed Dec 2 02:44:01 PST 2015


Hi Tony,

On 11/30/2015 09:51 PM, Tony Lindgren wrote:
> * Uri Mashiach <uri.mashiach at compulab.co.il> [151124 06:03]:
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am335x-cm-t335.dts
> ...
>
>> +&uart0 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&uart0_pins>;
>> +
>> +	status = "okay";
>> +};
>> +
>
> FYI, the extra line break at the end of the file causes whitespace
> warnings when applying. And fixing that causes extra hassles with
> applying the other patches in the series as the patches won't apply..
> So for the next time, you may want to check that ;)

Yes, I will definitely do that.

>
> Also, the subject line should be "ARM: dts: ..." for the dts changes
> so the git log loooks unified for all the ARM SoCs.

Got it. Thanks!

>
> Anyways, I've fixed up those locally and applying into omap-for-v4.5/dt.
>

Thank you Tony!

-- 
Regards,
Uri.



More information about the linux-arm-kernel mailing list