[PATCH V3] ARM: dts: imx6q-icore-rqs: Add Engicam IMX6 Q7 initial support

[Michael Trimarchi]

Hi

On Wed, Dec 2, 2015 at 3:09 AM, Shawn Guo <shawnguo at kernel.org> wrote:
> On Wed, Nov 25, 2015 at 07:14:13PM +0100, Michael Trimarchi wrote:
>> Hi Shawn
>>
>> On Wed, Nov 18, 2015 at 4:10 PM, Michael Trimarchi
>> <michael at amarulasolutions.com> wrote:
>> > www.engicam.com/en/products/embedded/som/standard/i-core-rqs-m6s-dl-d-q
>> >
>> > Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
>> > ---
>> > I'm not quite sure how ethernet tuning parameter
>> > are working in other setup and this seems the
>> > correct way to use it
>> >
>>
>> As you can see my way to connect the ethernet phy is different. I have
>> seen that most of the boards put all the tuning under fec but unfortunately
>> this does not work. I don't know if people check if their value are correctly
>> written to the phy.
>
> Hmm, I'm not sure what example you are looking at.  But here is what I
> see from arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
>
> &fec {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_enet>;
>         phy-mode = "rgmii";
>         phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
>         txen-skew-ps = <0>;
>         txc-skew-ps = <3000>;
>         rxdv-skew-ps = <0>;
>         rxc-skew-ps = <3000>;
>         rxd0-skew-ps = <0>;
>         rxd1-skew-ps = <0>;
>         rxd2-skew-ps = <0>;
>         rxd3-skew-ps = <0>;
>         txd0-skew-ps = <0>;
>         txd1-skew-ps = <0>;
>         txd2-skew-ps = <0>;
>         txd3-skew-ps = <0>;
>         interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
>                               <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
>         status = "okay";
> };
>

Yes sorry, could be only one. According in what I have seen this can
not work and the information stored in the
fec parameters are not written in the registers. Other small thing is
the IMX6/7 default config does not include
this phy at all, but that is a minor issue. Can you please do the
final review of my board so I can take care on this
too for Sabrelite?

Michael

> Shawn
>
>>
>> > +
>> > +&fec {
>> > +       pinctrl-names = "default";
>> > +       pinctrl-0 = <&pinctrl_enet_3>;
>> > +       phy-handle = <&eth_phy>;
>> > +       phy-mode = "rgmii";
>> > +       status = "okay";
>> > +       mdio {
>> > +               eth_phy: ethernet-phy {
>> > +                       rxc-skew-ps = <1140>;
>> > +                       txc-skew-ps = <1140>;
>> > +                       txen-skew-ps = <600>;
>> > +                       rxdv-skew-ps = <240>;
>> > +                       rxd0-skew-ps = <420>;
>> > +                       rxd1-skew-ps = <600>;
>> > +                       rxd2-skew-ps = <420>;
>> > +                       rxd3-skew-ps = <240>;
>> > +                       txd0-skew-ps = <60>;
>> > +                       txd1-skew-ps = <60>;
>> > +                       txd2-skew-ps = <60>;
>> > +                       txd3-skew-ps = <240>;
>> > +               };
>> > +       };
>> > +};
>> > +



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |