[PATCH 2/6] ARM: dts: sunxi: Add dtsi for AXP221 PMIC

[Chen-Yu Tsai]

On Tue, Sep 1, 2015 at 2:29 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> On Sat, Aug 29, 2015 at 10:07:12AM +0800, Chen-Yu Tsai wrote:
>> >> >> +
>> >> >> +&axp221 {
>> >> >> +     compatible = "x-powers,axp221";
>> >> >> +     interrupt-controller;
>> >> >> +     #interrupt-cells = <1>;
>> >> >> +
>> >> >> +     regulators {
>> >> >> +             /* Default work frequency for buck regulators */
>> >> >> +             x-powers,dcdc-freq = <3000>;
>> >> >> +
>> >> >> +             /* supplies for dc1sw & dc5ldo are connected internally */
>> >> >> +             dcdc1-supply = <&reg_dcdc1>;
>> >> >> +             dcdc5-supply = <&reg_dcdc5>;
>> >> >
>> >> > so the parent regulator of DCDC1 is DCDC1 ?
>> >>
>> >> These probably aren't the best names. These are the supplies for DC1SW and
>> >> DC5LDO, respectively. They are connected internally, so there aren't named
>> >> pins for them. The comment above explains it, though probably not clearly
>> >> enough. Furthermore, the input pins for DCDC1/5 are VIN1/5.
>> >
>> > I'm not quite sure I understand. They're connected internally but they
>> > have pins ?
>>
>> Internally, DCDC1's output feeds the input for DC1SW (which is just a switch
>> BTW) and DCDC5's output feeds DC5LDO (which is an LDO). Both these extra
>> regulators have separate controls. There are no external pins to name the
>> supplies after, so I just named them after which regulator supplies them.
>
> Well, there is. dc5ldo and dc1sw. And it is also how you called these
> regulators in your DT, so it would make much more sense to have it
> listed as such.

I was under the impression that we name them after the input pins. The names
are also documented in Documentation/devicetree/bindings/mfd/axp20x.txt

Do you want to change them?


Regards
ChenYu