[PATCH 3/3] soc: qcom: smd: Handle big endian CPUs

Bjorn Andersson bjorn.andersson at sonymobile.com
Mon Aug 31 22:06:44 PDT 2015


On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote:

> The smd structures are always in little endian, but the smd
> driver is not capable of being used on big endian CPUs. Annotate
> the little endian data members and update the code to do the
> proper byte swapping.
> 

I think this looks good, but I think it would be better to reference
the 8-bit entries of the info struct as "flags" rather than INFO8s.

Could you please change the name of the macros to
{G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to
follow?

Regards,
Bjorn



More information about the linux-arm-kernel mailing list