[PATCH v3 15/31] arm64: SMP support

Timur Tabi timur at codeaurora.org
Fri Aug 21 09:45:18 PDT 2015


On 08/10/2015 12:05 PM, Timur Tabi wrote:
>>>
>>> This code was inherited from arch/arm which initially was always dumping
>>> the stack but it later gained the system_state check. Unless it's useful
>>> to anyone for debugging purposes, I'm ok with removing it.
>>
>> Do you have patch for this one? My colleagues said that they met the
>> same problem :)
>
> Dropping the call to dump_stack() would probably be sufficient.

Actually, I think we need to keep it.  I just heard from another 
developer who does actually use it for debugging.

I think the real problem is that emergency_restart() should not be 
causing these outputs.  Shouldn't machine_restart() change the 
system_state to SYSTEM_RESTART before it calls smp_send_stop()?

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



More information about the linux-arm-kernel mailing list