[PATCH v3] pinctrl: mediatek: Fix multiple registration issue.
axel.lin at ingics.com
Thu Aug 20 22:08:24 PDT 2015
2015-08-21 12:46 GMT+08:00 Hongzhou Yang <hongzhou.yang at mediatek.com>:
> Since our common driver need support main chip and PMU
> at the same time, that means it will register two
> pinctrl device, and the pinctrl_desc structure should
> be used two times.
> But pinctrl_desc use global static definition, then
> the latest registered pinctrl device will overwrite
> the old one's, all members in pinctrl_desc will set to
> the new one's, such as name, pins and pins numbers, etc.
> This is a bug. Changing to use devm_kzalloc to fix it.
> Cc: stable at vger.kernel.org # v4.1+
> Signed-off-by: Hongzhou Yang <hongzhou.yang at mediatek.com>
> Use dynamic allocation to fix multiple registration issue.
The code looks good to me but the commit log needs fix.
You don't use devm_kzalloc now.
Just embedded struct pinctrl_desc pctl_desc to struct mtk_pinctrl.
Reviewed-by: Axel Lin <axel.lin at ingics.com>
More information about the linux-arm-kernel