[PATCH 3/3] [v2] hvc_dcc: disable user-space access to DCC
Timur Tabi
timur at codeaurora.org
Wed Aug 19 16:02:50 PDT 2015
If the DCC driver loads, then disable user-space access to the DCC so that
we don't have two entities trying to access the DCC at the same time.
Signed-off-by: Timur Tabi <timur at codeaurora.org>
---
arch/arm/include/asm/dcc.h | 15 +++++++++++++++
arch/arm64/include/asm/dcc.h | 11 +++++++++++
drivers/tty/hvc/hvc_dcc.c | 2 ++
3 files changed, 28 insertions(+)
diff --git a/arch/arm/include/asm/dcc.h b/arch/arm/include/asm/dcc.h
index b74899d..c50056b 100644
--- a/arch/arm/include/asm/dcc.h
+++ b/arch/arm/include/asm/dcc.h
@@ -9,8 +9,11 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
+#ifndef __ASM_DCC_H
+#define __ASM_DCC_H
#include <asm/barrier.h>
+#include <asm/hardware/cp14.h>
static inline u32 __dcc_getstatus(void)
{
@@ -39,3 +42,15 @@ static inline void __dcc_putchar(char c)
: "r" (c));
isb();
}
+
+static inline void __dcc_initialize(void)
+{
+ u32 val;
+
+ /* Disable user-space access to DCC */
+ val = MRC14(0, c0, c1, 0);
+ val |= 1 << 12; /* DSCR[Comms] */
+ MCR14(val, 0, c0, c1, 0);
+}
+
+#endif
diff --git a/arch/arm64/include/asm/dcc.h b/arch/arm64/include/asm/dcc.h
index 65e0190..cff9512 100644
--- a/arch/arm64/include/asm/dcc.h
+++ b/arch/arm64/include/asm/dcc.h
@@ -52,4 +52,15 @@ static inline void __dcc_putchar(char c)
isb();
}
+static inline void __dcc_initialize(void)
+{
+ u32 val;
+
+ /* Disable user-space access to DCC */
+ asm volatile ("mrs %0, mdscr_el1\n"
+ " orr %0, %0, #4096\n" /* Set the TDCC bit */
+ " msr mdscr_el1, %0\n"
+ : "=r" (val));
+}
+
#endif
diff --git a/drivers/tty/hvc/hvc_dcc.c b/drivers/tty/hvc/hvc_dcc.c
index 82f240f..14d4a473 100644
--- a/drivers/tty/hvc/hvc_dcc.c
+++ b/drivers/tty/hvc/hvc_dcc.c
@@ -75,6 +75,8 @@ static int __init hvc_dcc_console_init(void)
if (!hvc_dcc_check())
return -ENODEV;
+ __dcc_initialize();
+
/* Returns -1 if error */
ret = hvc_instantiate(0, 0, &hvc_dcc_get_put_ops);
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
More information about the linux-arm-kernel
mailing list