[PATCH V3] iommu/arm-smmu-v2: ThunderX mis-extends 64bit registers

Will Deacon will.deacon at arm.com
Tue Aug 18 05:44:48 PDT 2015


Hi Tirumalesh,

On Tue, Aug 18, 2015 at 12:13:55AM +0100, tchalamarla at caviumnetworks.com wrote:
> From: Tirumalesh Chalamarla <tchalamarla at caviumnetworks.com>
> 
> The SMMU architecture defines two different behaviors when 64-bit
> registers are written with 32-bit writes.  The first behavior causes
> zero extension into the upper 32-bits.  The second behavior splits a
> 64-bit register into "normal" 32-bit register pairs.
> 
> On some buggy implementations, registers incorrectly zero extended
> when they should instead behave as normal 32-bit register pairs.
> 
> Signed-off-by: Tirumalesh Chalamarla <tchalamarla at caviumnetworks.com>
> 
> Changes from V2:
> 	- removed unused definitions
> 
> Changes from V1:
> 	- Introduced smmu_writeq
> ---
>  drivers/iommu/arm-smmu.c | 57 +++++++++++++++++++++++++-----------------------
>  1 file changed, 30 insertions(+), 27 deletions(-)

I'm happy with this, but it doesn't apply against mainline or my tree.
Please can you rebase it onto something more recent, preferably my
iommu/devel branch?

Thanks,

Will



More information about the linux-arm-kernel mailing list