[PATCH 2/3] Display a DMA error message
Arnd Bergmann
arnd at arndb.de
Fri Aug 14 14:19:46 PDT 2015
On Wednesday 12 August 2015 16:51:29 Jeremy Linton wrote:
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index 2593def..82e396f 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)
>
> err = dma_coerce_mask_and_coherent(&dev->dev,
> pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
> - if (err)
> + if (err) {
> + dev_err(&dev->dev, "Error: DMA setup failed\n");
> return err;
> + }
We should really stop doing this: the platform should provide the
correct dma mask when creating the device, instead of setting a
bogus pdata field. Do not duplicate this bug for ACPI.
Arnd
More information about the linux-arm-kernel
mailing list