[PATCH 2/9] PM / Domains: Remove dev->driver check for runtime PM
khilman at kernel.org
Thu Aug 13 20:40:42 PDT 2015
Geert Uytterhoeven <geert at linux-m68k.org> writes:
> Hi Kevin,
> On Wed, Aug 12, 2015 at 9:50 PM, Kevin Hilman <khilman at kernel.org> wrote:
>> Lina Iyer <lina.iyer at linaro.org> writes:
>>> Remove check for driver of a device, for runtime PM. Device may be
>>> suspended without an explicit driver. This check seems to be vestigial
>>> and incorrect in the current context.
>> This one should probably have been RFC.
>> For a little more context here, this was uncovered when experimenting
>> with using runtime PM for CPU devices which don't have a dev->driver.
>> This check might have made sense before PM domains, but with PM domains,
>> it's entirely possible to have a simple device without a driver and the
>> PM domain handles all the necesary PM, so I think this check
>> could/should be removed.
> Simple devices without a driver aren't handled automatically.
> At minimum, the driver should call pm_runtime_enable(), cfr.
That's correct, and in the proof-of-concept stuff I hacked up and in
Lina's series, the CPU "devices" do indeed to this. Without that, they
wouldn't end up ever taking this codepath through genpd's
runtime_suspend and power_off hooks.
Also, I'm not sure if your comment was meant to be an objection to the
patch? or if you're OK with it.
Thanks for the feedback,
More information about the linux-arm-kernel